implement py-car-wash-station #1632
Conversation
There was a problem hiding this comment.
Great job on implementing the Car and CarWashStation classes! 🎉 Your code meets the task requirements and constraints effectively. Just a couple of things to keep in mind for future improvements: ensure the rate parameter in rate_service is within a valid range to prevent invalid ratings, and consider handling the potential division by zero in calculate_washing_price. Keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| return round( | ||
| car.comfort_class * (self.clean_power - car.clean_mark) | ||
| * self.average_rating / self.distance_from_city_center, 1) |
There was a problem hiding this comment.
There is a potential division by zero error in calculate_washing_price if distance_from_city_center is zero. Consider adding a check to prevent this scenario.
| def rate_service(self, rate: int) -> None: | ||
| new_rate = ((self.average_rating * self.count_of_ratings) | ||
| + rate) / (self.count_of_ratings + 1) | ||
| self.average_rating = round(new_rate, 1) | ||
| self.count_of_ratings += 1 |
There was a problem hiding this comment.
Ensure that the rate parameter in rate_service is within a valid range (e.g., 1 to 5) to prevent invalid ratings from being processed.
No description provided.